Closed lelandrichardson closed 7 years ago
cc @spikebrehm
We regularly use tools like git log
, git blame
, and git show
to understand why a particular line of code is the way it is. To help out our future selves, it would be really great if you could capture the "why" in each of your commit messages. More info: https://brigade.engineering/the-secrets-to-great-commit-messages-106fc0a92a25
@lencioni @trotzig I've addressed most feedback. Think this is ready to merge now?
I didn't look too closely at the updated commits, but if you feel good about it, go for it.
I'm all 👍
to: @lencioni @trotzig
This PR is broken into 3 commits.
The first commit is
Add RN Runner App
, which is mostly just the output ofreact-native init HappoRunner
to create a standard RN app. The app is only tweaked in a couple of small ways to allow for the snapshotting. This commit could mostly be ignored.The second commit is
Add RN Target
which adds the actual happo target plugin. The plugin does the following:Tested with both iOS and Android.
The third commit is another "example" project that shows the example in action.