search

Galooshi / happo

Visual diffing in CI for user interfaces
504 stars 16 forks source link

Enhance documentation for supported targets #195

Open DanielMSchmidt opened 7 years ago

DanielMSchmidt commented 7 years ago

Hi there,

This seems like an awesome project and I am so excited to try it out, but I only stumbled on its support for React Native only by seeing a related PR. I have the feeling a lot of features are missing in the docs. If this is the case I would be happy to provide a PR.

Regards!

trotzig commented 7 years ago

Thanks! I think the reason RN support is not in the README is because @lelandrichardson and others over at Airbnb are still working on making it robust. I don't have full visibility into their plans, perhaps @lencioni can chime in?

DanielMSchmidt commented 7 years ago

Oh okay, then maybe adding a beta section to the readme or something similar could be a good idea? Just so that the current status is clearly communicated and I know that I may try it but it also might eventually break.

lencioni commented 7 years ago

That's right. @lelandrichardson and @spikebrehm are working on React Native which will be part of the 5.0.0 release.

tlvenn commented 5 years ago

Hi, did the RN target make it to the 5.0.0 release ? What is the current status of that target ? Thanks !

trotzig commented 5 years ago

Unfortunately, work there was never finished up. I'm mainly maintaining this project on a bug-fix basis. I'm focusing on happo.io, which is a continuation of this project.

tlvenn commented 5 years ago

I would be very happy to be a customer of happo.io, does it support RN ?

trotzig commented 5 years ago

I'll provide a short answer here and then I'll elaborate in a direct email to you @tlvenn.

There's no built-in RN renderer, but happo.io has an API that you can use with any platform, as long as you can produce screenshots yourself.

tlvenn commented 5 years ago

Thanks @trotzig !