search

Galooshi / happo

Visual diffing in CI for user interfaces
504 stars 16 forks source link

selenium-webdriver 3.4.0 breaks Happo 4 #200

Closed lencioni closed 7 years ago

lencioni commented 7 years ago

Our Happo builds started failing with output like:

(node:2070) DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
/home/travis/build/org/project/node_modules/selenium-webdriver/lib/promise.js:2634
        throw error;
        ^
WebDriverError: Unable to parse new session response:
{"sessionId":"c22dff5b-04a4-41a1-804a-59b106ca81ec","value":{"acceptInsecureCerts":false,"browserName":"firefox","browserVersion":"52.0.1","moz:accessibilityChecks":false,"moz:processID":2096,"moz:profile":"/tmp/rust_mozprofile.6Kn1fST0TASk","pageLoadStrategy":"normal","platformName":"linux","platformVersion":"3.13.0-105-generic","rotatable":false,"specificationLevel":0,"timeouts":{"implicit":0,"page
load":300000,"script":30000}}}

I diffed the output of npm install and noticed that selenium-webdriver went from 3.3.0 to 3.4.0. Pinning it at 3.3.0 allowed the build to succeed. I haven't had time to look into this any deeper.

suchipi commented 7 years ago

I'm also seeing this issue after installing and running happo for the first time