Open majapw opened 7 years ago
This is a good idea. I think the best way to apply this would be on the review page, dynamically. It looks like we're only passing viewportName
to that view, so doing this would be a two-fold thing:
runVisualDiffs
saves the viewport width along with the name. Somewhere around here: https://github.com/Galooshi/happo/blob/c291f5fa9e729e49c8b1d2246a288da18ed51052/packages/happo-target-firefox/src/runVisualDiffs.js#L202NewImage
React component: https://github.com/Galooshi/happo/blob/c291f5fa9e729e49c8b1d2246a288da18ed51052/packages/happo-viewer/src/NewImage.jsx
When an initial screenshot is taken with happo of a new example, there is no indication of whether or not any of the content is rendered outside of the viewport. The screenshot just stretches to display the whole content. It would be pretty cool if there were a border or something similar to indicate where the actual viewport was.
fyi: @lencioni