Galooshi / happo

Visual diffing in CI for user interfaces
504 stars 16 forks source link

No way to tell when a new screenshot is rendering outside the viewport #206

Open majapw opened 7 years ago

majapw commented 7 years ago

When an initial screenshot is taken with happo of a new example, there is no indication of whether or not any of the content is rendered outside of the viewport. The screenshot just stretches to display the whole content. It would be pretty cool if there were a border or something similar to indicate where the actual viewport was.

fyi: @lencioni

trotzig commented 7 years ago

This is a good idea. I think the best way to apply this would be on the review page, dynamically. It looks like we're only passing viewportName to that view, so doing this would be a two-fold thing: