search

Galooshi / happo

Visual diffing in CI for user interfaces
504 stars 16 forks source link

[happo-viewer] Bump worker-loader ^0.7.1 -> ^1.0.0 #214

Closed lencioni closed 6 years ago

lencioni commented 6 years ago

worker-loader pre-1.0.0 has a peerDependency that does not allow webpack

  1. This prevents projects that want to update to webpack 3 from getting onto that version.

The only breaking change listed here is about loader-utils, which I don't think will impact this project.

https://github.com/webpack-contrib/worker-loader/releases/tag/v1.0.0

kesne commented 6 years ago

This LGTM!

lencioni commented 6 years ago

It seems that lerna bootstrap is failing in CI. I was able to reproduce locally, but also work around it by going into individual package directories and npm installing there. Now lerna bootstrap works locally. I believe I am running into this issue: https://github.com/lerna/lerna/issues/785

lencioni commented 6 years ago

I think this is safe to merge, and I'd like to unblock webpack 3, so I'll be publishing a new release soon. We should possibly follow up with investigating the issues here soon...