search

Galooshi / happo

Visual diffing in CI for user interfaces
504 stars 16 forks source link

requestAnimationFrame is not defined #222

Open coldpour opened 6 years ago

coldpour commented 6 years ago

Hey there,

I was wondering if you could help me figure out if this is a Happo issue or not. It looks like its coming from jsdom. Is this something that you might like to polyfill? You can see my build for more context.

https://travis-ci.org/mineral-ui/mineral-ui/jobs/338758728

Thanks, Mike

trotzig commented 6 years ago

Let me have a look.

trotzig commented 6 years ago

It might make sense to have a global polyfill for this. In the meantime, you can probably add your own polyfill using the setupScript config option: https://github.com/enduire/happo.io#setupscript

Oh, and this issue was filed in the wrong repo. New happo is in https://github.com/enduire/happo.io

coldpour commented 6 years ago

Perfect. Thanks for your help. And sorry for reporting in the wrong place!

On Thu, Feb 8, 2018 at 1:48 PM Henric Trotzig notifications@github.com wrote:

It might make sense to have a global polyfill for this. In the meantime, you can probably add your own polyfill using the setupScript config option: https://github.com/enduire/happo.io#setupscript

Oh, and this issue was filed in the wrong repo. New happo is in https://github.com/enduire/happo.io

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Galooshi/happo/issues/222#issuecomment-364243527, or mute the thread https://github.com/notifications/unsubscribe-auth/AKXd7JVvTvzmHaRXicZ-mngJsSNTKX5Lks5tS12YgaJpZM4R-uCc .