Galooshi / happo

Visual diffing in CI for user interfaces
504 stars 16 forks source link

Fix grabbing urls from srcset attributes #224

Closed trotzig closed 6 years ago

trotzig commented 6 years ago

My first attempt at this (312ecd9) was too naive, it didn't take urls with commas in them into account. In this second attempt, I've tried to tdd things so that I know we can handle a wider range of values.

I've used https://developer.mozilla.org/en-US/docs/Web/HTML/Element/img as a guide into figuring out possible values.