Use string.prototype.matchall to grab urls from srcset - Githubissues

Galooshi / happo

Visual diffing in CI for user interfaces

504 stars 16 forks source link

Use string.prototype.matchall to grab urls from srcset #225

Closed trotzig closed 6 years ago

trotzig commented 6 years ago

As pointed out by @ljharb in a previous PR: https://github.com/Galooshi/happo/pull/224#pullrequestreview-127401748

Multiple benefits here:

we avoid the while-loop
no mutation of the lastIndex property of the regexp