Replace srcset parsing regex with parse-srcset package

Galooshi / happo

Visual diffing in CI for user interfaces

504 stars 16 forks source link

Replace srcset parsing regex with parse-srcset package #229

Closed lencioni closed 5 years ago

lencioni commented 5 years ago

We found a bug where srcsets with multiple URLs and mixed descriptors would be parsed incorrectly, causing the first URL without a descriptor to include a trailing comma. Instead of relying on this regex, I found what appears to be a good package for parsing this string according to the spec.

@trotzig @ljharb @sharmilajesupaul