search

Galooshi / happo

Visual diffing in CI for user interfaces
505 stars 16 forks source link

Allow additional directories to be specified in the config #86

Closed serena-w closed 8 years ago

serena-w commented 8 years ago

I added a way for diffux to be configured to look for resources in other directories. This allows the usage of custom fonts and resolves the issue https://github.com/diffux/diffux_ci/issues/82. I also added a test to check that diffux can find files in other directories specified in its config.

fixes #82

lencioni commented 8 years ago

It might be good to document some of the approaches you considered or tried in your commit message and why you landed on the catch-all route.

lencioni commented 8 years ago

It also looks like your test did not pass in CI, FYI.

lencioni commented 8 years ago

one minor comment, otherwise this looks good. Thanks for working on this!

trotzig commented 8 years ago

Thanks @serena-w! This is a great addition!

trotzig commented 8 years ago

I just have to say a big THANK YOU for this change. We recently switched font-loading strategy at brigade.com (to the "Critical FOFT with data URI" technique), and I was able to make our happo run happy by simply adding a line to our config. Thanks!