Galooshi / sublime-import-js

Sublime Text plugin for ImportJS
MIT License
24 stars 2 forks source link

Code of conduct link is invalid in CONTRIBUTING.md #20

Closed monovertex closed 6 years ago

monovertex commented 6 years ago

I plan on opening a PR to fix #1 and #19, but I'm not sure if there any special rules or guidelines to follow when writing the code.

Unfortunately the link to the code of conduct (http://todogroup.org/opencodeofconduct/#Import-JS/henric.trotzig@gmail.com) seems to be dead.

trotzig commented 6 years ago

That would be great! Just make sure you explain your changes well and keep them isolated (either different PRs or different commits) and you’re good to go. Bear in mind that some of the code in here is written by people without much python experience (e.g. me!) so if you see room for improvement, don’t hesitate to make the change!

monovertex commented 6 years ago

@trotzig, I opened a Pull Request to address this issue, add a linter and fix several linting issues. Please take a look at it when you have the time. Thanks!