GaloyMoney / blink

bitcoin banking infrastructure
https://galoy.io
MIT License
370 stars 137 forks source link

add paymentRequest to Transaction / InitiateVia #3630

Closed nicolasburtey closed 11 months ago

nicolasburtey commented 11 months ago

when paying over lightning, we currently don't expose the lightning invoice / payment request after the fact in the transaction object - or in the transaction detail page in the mobile app

This is needed to make a proper proof of payment, because the proof of payment consist of:

  1. the lightning invoice - signed by the recipient node
  2. the pre-image, showing that we have paid the invoice

We should store this in the db, and expose it to the mobile app to serve as a complimentary to the proof of payment

In addition, I would love to get this paymentRequest also exposed in the mobile app for my own discoverability of who do what when I'm using the app day to day. If I'm in front of a cashier, I'm going to pay the invoice quickly. but often, after the fact, I may wonder who is the node provider behind the service I just paid. Having the invoice would make it easier to discover this just by copying the invoice to lightningdecoder.com

nicolasburtey commented 11 months ago

this has been done