Macros not working properly?

Galzai / MK32

Keyboard firmware for ESP32 microcontrollers

667 stars 117 forks source link

Macros not working properly? #14

Open cmpulsip opened 4 years ago

cmpulsip commented 4 years ago

I've followed the project for quite some time, and have recently built and started using my keyboard utilizing the esp32's. It works pretty much flawlessly, so I commend you on all the work you've done, but I have an issue with the macros. I believe I've defined them properly, but they're not working. I am using Macosx Catalina, I don't know if the operating system has something to do with this issue? I was wondering if you've been able to use them in a split keyboard application? I'm not sure what supporting documentation you need. Let me know and I'll do my best to get them to you if you're willing/able to address this issue.

Galzai commented 4 years ago

Hey, Just to make sure everything is set-up correctly, it would help to know:

what actually happens when you set a macro and try to launch it.
have you tried any of the pre-set macros, do they work?
can you share your macro implementation? ( i.e. the changes you made to enable the macros).

cmpulsip commented 4 years ago

From what I can tell, there isn't any visible response when I try to use a macro.
Macosx doesn't have an equivalent ctl+alt+delete, and that's the only macro that I see has been defined?
I have attached the keymap.c. keymap.c.zip

Thanks for the quick reply. Looking forward to getting this working. Again, great work! Much appreciated!

Galzai commented 4 years ago

I'll try and look into it, but it will take some time, if you find the issue before I manage to get around to it it would be great if you could do a pull request!

cmpulsip commented 3 years ago

Hey, I know it's been a ridiculously long time since I raised this issue, but I finally got around to do some testing.

It looks like there may be an issue with the way the macros and modifiers are being populated in current_report. I changed the macro logic to be:

uint16_t key = macros[keycode - MACRO_BASE_VAL][i];

This change made some of the macros work, but then the modifier keys stopped working, such as shift, command, alt, etc...

Still looking into it, but if you had any ideas, I'd be open to any suggestions... Still poking around.