libyuv.gyp doesn't define 'clang' variable.

GoogleCodeExporter commented 8 years ago

What steps will reproduce the problem?
1. Write a .gyp that uses libyuv.gyp as a dependency
2. Try generating the project.

What is the expected output? What do you see instead?
Expect a successful build. Instead GYP will stop at libyuv.gyp:66 due to 
undefined variable 'clang'.

What version of the product are you using? On what operating system?
1559 on Linux.

Please provide any additional information below.
If you run the ./gyp_libyuv script, it automatically includes the chromium 
common .gyp files, which give a default value to the 'clang' variable. 
libyuv.gyp should also assign a default value to 'clang' variable so it can be 
used standalone. ('clang%': 0)

Original issue reported on code.google.com by dhr...@google.com on 5 Jan 2016 at 4:12

GoogleCodeExporter commented 8 years ago

The following revision refers to this bug:
  https://chromium.googlesource.com/libyuv/libyuv.git/+/2560df9513e66080524a5b8dcea92b8ec657a8eb

commit 2560df9513e66080524a5b8dcea92b8ec657a8eb
Author: Frank Barchard <fbarchard@google.com>
Date: Tue Jan 05 19:47:55 2016

add clang variable for other apps to use

R=dhrosa@google.com
BUG=libyuv:539

Review URL: https://codereview.chromium.org/1557923005 .

[modify] 
http://crrev.com/2560df9513e66080524a5b8dcea92b8ec657a8eb/README.chromium
[modify] 
http://crrev.com/2560df9513e66080524a5b8dcea92b8ec657a8eb/include/libyuv/version
.h
[modify] http://crrev.com/2560df9513e66080524a5b8dcea92b8ec657a8eb/libyuv.gyp

Original comment by bugdroid1@chromium.org on 5 Jan 2016 at 7:48

GoogleCodeExporter commented 8 years ago

Fixed in r1562

Original comment by fbarch...@google.com on 5 Jan 2016 at 7:49

Changed state: Fixed

Gamaru / libyuv

libyuv.gyp doesn't define 'clang' variable. #539