search

Gamaru / libyuv

Automatically exported from code.google.com/p/libyuv
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Row_ name consistency #562

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
Row functions should be named same as image functions, with appendix Row_CPU

e.g. 
image function:  Blend()
row function:    BlendRow_AVX2()

Original issue reported on code.google.com by fbarch...@google.com on 27 Jan 2016 at 1:07

GoogleCodeExporter commented 8 years ago

Original comment by fbarch...@google.com on 5 Feb 2016 at 7:15

GoogleCodeExporter commented 8 years ago 
The following revision refers to this bug:
  https://chromium.googlesource.com/libyuv/libyuv.git/+/0d880e5bc07cde197a5a0a4e1bb4bda408373f6f

commit 0d880e5bc07cde197a5a0a4e1bb4bda408373f6f
Author: Frank Barchard <fbarchard@google.com>
Date: Fri Feb 05 22:49:54 2016

rename MIPS_DSPR2 to DSPR2 for consistency

When attempting to normalize function names to end in Row_SIMD it was made
harder with MIPS_DSPR2 naming convention.
Other CPUs do not include the vendor.  This should be named consistently.

Removed the DISABLE_MIPS in favour of DISABLE_ASM for consistency with other
processors.

TBR=harryjin@google.com
BUG=libyuv:562

Review URL: https://codereview.chromium.org/1677633002 .

[modify] 
http://crrev.com/0d880e5bc07cde197a5a0a4e1bb4bda408373f6f/README.chromium
[modify] 
http://crrev.com/0d880e5bc07cde197a5a0a4e1bb4bda408373f6f/include/libyuv/cpu_id.
h
[modify] 
http://crrev.com/0d880e5bc07cde197a5a0a4e1bb4bda408373f6f/include/libyuv/rotate_
row.h
[modify] 
http://crrev.com/0d880e5bc07cde197a5a0a4e1bb4bda408373f6f/include/libyuv/row.h
[modify] 
http://crrev.com/0d880e5bc07cde197a5a0a4e1bb4bda408373f6f/include/libyuv/scale_r
ow.h
[modify] 
http://crrev.com/0d880e5bc07cde197a5a0a4e1bb4bda408373f6f/include/libyuv/version
.h
[modify] 
http://crrev.com/0d880e5bc07cde197a5a0a4e1bb4bda408373f6f/source/convert.cc
[modify] 
http://crrev.com/0d880e5bc07cde197a5a0a4e1bb4bda408373f6f/source/convert_argb.cc
[modify] 
http://crrev.com/0d880e5bc07cde197a5a0a4e1bb4bda408373f6f/source/convert_from.cc
[modify] 
http://crrev.com/0d880e5bc07cde197a5a0a4e1bb4bda408373f6f/source/cpu_id.cc
[modify] 
http://crrev.com/0d880e5bc07cde197a5a0a4e1bb4bda408373f6f/source/planar_function
s.cc
[modify] 
http://crrev.com/0d880e5bc07cde197a5a0a4e1bb4bda408373f6f/source/rotate.cc
[modify] 
http://crrev.com/0d880e5bc07cde197a5a0a4e1bb4bda408373f6f/source/rotate_any.cc
[modify] 
http://crrev.com/0d880e5bc07cde197a5a0a4e1bb4bda408373f6f/source/rotate_mips.cc
[modify] 
http://crrev.com/0d880e5bc07cde197a5a0a4e1bb4bda408373f6f/source/row_any.cc
[modify] 
http://crrev.com/0d880e5bc07cde197a5a0a4e1bb4bda408373f6f/source/row_mips.cc
[modify] 
http://crrev.com/0d880e5bc07cde197a5a0a4e1bb4bda408373f6f/source/scale.cc
[modify] 
http://crrev.com/0d880e5bc07cde197a5a0a4e1bb4bda408373f6f/source/scale_argb.cc
[modify] 
http://crrev.com/0d880e5bc07cde197a5a0a4e1bb4bda408373f6f/source/scale_common.cc
[modify] 
http://crrev.com/0d880e5bc07cde197a5a0a4e1bb4bda408373f6f/source/scale_mips.cc
[modify] 
http://crrev.com/0d880e5bc07cde197a5a0a4e1bb4bda408373f6f/unit_test/cpu_test.cc
[modify] http://crrev.com/0d880e5bc07cde197a5a0a4e1bb4bda408373f6f/util/cpuid.c

Original comment by bugdroid1@chromium.org on 5 Feb 2016 at 10:50

GoogleCodeExporter commented 8 years ago 
Started but not complete.
Current names for some 'Plane' functions replace the word Plane with Row.

Row functions should typically look like

FunctionRow_Any_SSE2
where Function is typically a verb

Original comment by fbarch...@google.com on 16 Feb 2016 at 7:24