Gamatora / gource

Automatically exported from code.google.com/p/gource
0 stars 0 forks source link

makefiles fixes to respect HOST and LDFLAGS #34

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
The current build system doesn't respect the HOST and BUILD target given to
configure. this is becouse CXX is statically assigned in Makefile.in .
Another issue is that $(LDFLAGS) is missing when linking gource executable.
I also changed the mv gource with cp gource since if i use make && make
install gource will be linked twice since the target has been moved and
make install doens't find it. I've done a patch to fix this (attached). 

I've done this patch couse i've written a package for the gentoo
distribution and this is needed for QA test pass. I think other distros
want this too, so pls merge this.

I've tested this with version 0.23 but it should work also on master.

While i was working on this i noticed that the build system can be improved
even more, so if you want feel free to ask and i will provide it! For
example the for loop in target all can be avoided when make install is
called if i already called make all (or just make) before to compile.
Currently if i call make && make install that for is called twice, and this
is useless. The mv gource is not needed too with some mod to the makefiles

Original issue reported on code.google.com by enrico.t...@gmail.com on 18 Jan 2010 at 1:53

Attachments:

GoogleCodeExporter commented 9 years ago
Hi. Someone just sent me a rewrite of the build system using automake, so I'll 
make a
look at that and see if it addresses this too.

Original comment by acaudw...@gmail.com on 18 Jan 2010 at 6:16

GoogleCodeExporter commented 9 years ago
The person who sent it to you is my mentor (the one who asked for the gentoo 
package)
so i already saw that fix and it has been done for this, it addresses these 
issues.
if you merge that you can safely close this issue as resolved.

Cheers

Original comment by enrico.t...@gmail.com on 18 Jan 2010 at 2:31

GoogleCodeExporter commented 9 years ago
Hi. This is the version I intend to release.

http://gource.googlecode.com/files/gource-0.24-beta2.tar.gz

It would be good to get some feedback on the install hook's where I've gzipped 
the
man page, because that's what the previous versions did. I couldn't find a 
tidier way
to do this (automake doesn't seem to know what to go if you give it a 
compressed man
page to install):

Original comment by acaudw...@gmail.com on 31 Jan 2010 at 10:33

GoogleCodeExporter commented 9 years ago
As i understand it is all ok. I adapted the gentoo package for the beta2 and it 
works
like a charm. The man pages is installed and detected by man gource as expected 
here.
Thank you.

Cheers

Original comment by enrico.t...@gmail.com on 1 Feb 2010 at 1:16

GoogleCodeExporter commented 9 years ago
Hi. I just posted the final version:

http://gource.googlecode.com/files/gource-0.24.tar.gz

Original comment by acaudw...@gmail.com on 1 Feb 2010 at 11:47

GoogleCodeExporter commented 9 years ago
Quick :D gentoo package should hit the tree soon (replacing the beta2). Thanks 
for
the notify

Cheers

Original comment by enrico.t...@gmail.com on 2 Feb 2010 at 12:36

GoogleCodeExporter commented 9 years ago
Cool. Thanks for packaging Gource :)

Original comment by acaudw...@gmail.com on 2 Feb 2010 at 7:59

GoogleCodeExporter commented 9 years ago
Thank you for coding it :D

Original comment by enrico.t...@gmail.com on 3 Feb 2010 at 2:15