Gource end before term when --output-ppm-stream is given

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Try to save the image stream to a file (as PPM)
2. Run Gource without --stop-at-end
3. Gource stop before the last commit and do not provide a view of the
project without move just as it is when the gource is run without the
--output-ppm-stream.

What is the expected output? 

The expected result should be the view to keep going without any
modification (only date should be running).

What do you see instead?

Gource exit.

What version of the product are you using? On what operating system?

0.26

Please provide any additional information below.

Original issue reported on code.google.com by emmanuel...@gmail.com on 11 Mar 2010 at 8:51

[GoogleCodeExporter]

You probably need to add --stop-on-idle to get the effect you are looking for.

Original comment by acaudw...@gmail.com on 11 Mar 2010 at 9:27

[GoogleCodeExporter]

Didn't work either. :-/

In fact, I really would like to stop the video encoding when I close the window 
by
myself. Not to give gource the hand on the choice of the exit (somehow, it 
should
mimic the behavior when no PPM output is asked).

By the way, your software is really amazing ! I love it (I did look at the code 
and
I'm really loving it). Thanks a lot for writing it. :)

Original comment by emmanuel...@gmail.com on 11 Mar 2010 at 9:48

[GoogleCodeExporter]

I think I found the problem.

You force stop_at_end to be true when ppm_file_name.size() is greater than zero:

    if(ppm_file_name.size() > 0) {
        //recording a video kind of implies you want this
        stop_at_end = true;

        try {

        } catch(PPMExporterException& exception) {

In main.cpp.

Original comment by emmanuel...@gmail.com on 11 Mar 2010 at 10:08

[GoogleCodeExporter]

Well, what is happening is --output-ppm-stream enables --stop-at-end as people
normally don't want to have to monitor Gource while its going.

For now you could edit src/main.cpp and comment out stop_at_end = true as seen 
here:

if(ppm_file_name.size() > 0) {
    //recording a video kind of implies you want this
    stop_at_end = true;
...

Original comment by acaudw...@gmail.com on 11 Mar 2010 at 10:08

[GoogleCodeExporter]

Yeah, exactly.

Original comment by acaudw...@gmail.com on 11 Mar 2010 at 10:10

[GoogleCodeExporter]

Sorry, I didn't refresh the webpage. Thanks anyway, it's working fine after
commenting this line. :)

Original comment by emmanuel...@gmail.com on 11 Mar 2010 at 10:11

[GoogleCodeExporter]

Cool. Maybe I could add an option to negate this.

Original comment by acaudw...@gmail.com on 11 Mar 2010 at 10:59

[GoogleCodeExporter]

Maybe you should just let the option defined by the command line to be used 
here.

May I suggest the following:

--no-stop: Let the image untouched and keep going when log is finished

--stop-at-time SEC: Stop after SEC seconds

--file-idle-time 0: should leave the file untouched

If I have time I might suggest some patches for these suggestions... These are 
quite
easy (it's just option handling).

Original comment by emmanuel...@gmail.com on 11 Mar 2010 at 11:11

[GoogleCodeExporter]

Hi. I've implemented your suggestions (did not have a whole lot going on this
afternoon...):

--dont-stop
--stop-at-time
--file-idle-time 0

Cheers

Andrew

Original comment by acaudw...@gmail.com on 12 Mar 2010 at 2:03

[GoogleCodeExporter]

Original comment by acaudw...@gmail.com on 12 Mar 2010 at 2:03

• Changed state: Fixed

[GoogleCodeExporter]

Thanks a lot !

Original comment by emmanuel...@gmail.com on 12 Mar 2010 at 7:58