Missing return at end of 'parse' in src/commitLog.cpp:59

[GoogleCodeExporter]

Version 0.27, building from source with (free) Intel C++ Compiler:

 58     void debug();
 59     virtual bool parse(BaseLog* logf) {};
 60 };

Generates a warning:

src/commitlog.h(59): warning #1011: missing return statement at end of non-void 
function "RCommit::parse"
      virtual bool parse(BaseLog* logf) {};

(Also, the semicolon is unnecessary since you have supplied a compound 
statement)

Presumably this should be either

  virtual bool parse(BaseLog* logf) { return false; }
  virtual bool parse(BaseLog* logf) { return true; }
or
  virtual bool parse(BaseLog* logf) = 0;

?

Original issue reported on code.google.com by kfs...@gmail.com on 7 Aug 2010 at 6:04

[GoogleCodeExporter]

Ooops, src/commitlog.h, not commitlog.cpp

Original comment by kfs...@gmail.com on 7 Aug 2010 at 6:04

[GoogleCodeExporter]

Original comment by acaudw...@gmail.com on 8 Aug 2010 at 11:30

• Changed state: Accepted

[GoogleCodeExporter]

Original comment by acaudw...@gmail.com on 13 Aug 2010 at 2:52

• Changed state: Done