search

Game-X-Coin / eosjs-rn

General purpose library for the EOS blockchain.
http://eosio.github.io/eosjs
MIT License
18 stars 5 forks source link

fork from v16.0.9? #2

Closed jadertao closed 6 years ago

jadertao commented 6 years ago

this repo is forked from beta v20.0.1, which is still in develop and lacks some important api, so how about fork from v.16.0.9.

indiev commented 6 years ago

I added eosjs-rn from v16.0.9. you cat use it by typing 'npm install eosjs-rn@16.0.9' or 'yarn add eosjs-rn@16.0.9'. but, I removed 'function wasmCodeOverride in structs.js' and 'test code from eosjs-keygen' for compatibility reasons. i also needed to add fork modules eosjs-api-rn, eosjs-fcbuffer-rn

jadertao commented 6 years ago

many thanks. btw, src/ripemd.js uses Proxy which is not supported in RN. This file is imported only in src/eosjs-numeric. maybe it can use src/ripemd.es5.js instead. ———————————————————— edit: sorry, i found that src/ripemd.es5.js still use Proxy.

jadertao commented 6 years ago

I find a way to avoid Proxy. see https://gist.github.com/wlzla000/bac83df6d3c51916c4dd0bc947e46947 and made a PR.

indiev commented 6 years ago

thanks @JadeTao i merged your PR. The reason why eosjs did not write ripemd5 in eosjs-ecc is directly implemented it is because it did not provide ripemd5 in eosjs-ecc. So I added ripemd5 api to eosjs-ecc-rn to use. I thought it would be better to use the module eosjs-ecc api instead of using ripemd5.js as it is. patch eosjs-rn@20.0.0-beta2.1