search

Game-as-a-Service / Machi-Koro-Cpp

5 stars 1 forks source link

35.refresh controller usecase and domain #38

Closed HuaYuan-Tseng closed 7 months ago

HuaYuan-Tseng commented 7 months ago
  1. Rebuild all the Clean Architecture ( Controller -- (UsecaseRequest)--> Usecase --> Domain -- (DomainEvent) --> Presenter --> Controller ).
  2. Add Clang-Format.
  3. Rewrite the e2e_test.
YingChen-Lee commented 7 months ago

LGTM. I didn't go though all the details, but overall it looks good! I think it's okay to merge, and we can create another ticket if we want to add or modify something else.

HuaYuan-Tseng commented 7 months ago

I'll merge first. If something else need to discuss, open other ticket.