search

GameAnalytics / GA-SDK-GODOT

Official GameAnalytics Godot SDK repository
MIT License
42 stars 7 forks source link

Fixes multiple singleton creation error on Godot .Net builds. #29

Closed sabvdf closed 6 months ago

sabvdf commented 7 months ago

In Godot 4.x .Net builds, the current process launches multiple phases, this check needs to be added to have the GA module work with .Net builds. (Some issues remain with the builds though, but with this I currently do have GA working in the Godot Editor on macOS)

Side note: Please tell someone to change the name of Godot on your web site, on some occasions it says GoDot which is incorrect and cringe.

dorin-ga commented 7 months ago

Hello, thank you for your contribution! Regarding the documentation could you please share the pages on which you found the typo please?

sabvdf commented 7 months ago

Hello, thank you for your contribution! Regarding the documentation could you please share the pages on which you found the typo please?

Oh yeah sorry, I saw it in Create Game, SDK integration.

By the way, I'm working on making this into a GDExtension, got it working for macOS, currently working on iOS and getting the libraries included correctly; if someone over there is currently also working on this, it may be a good idea to compare efforts? My progress is in the gdextension branch of my fork.

dorin-ga commented 6 months ago

About the GDExtension, it is something we have considered, but unfortunately our team had other priorities at the moment. We will revisit it in the near future and I'll be glad to take a look over your branch/PR.