GameAnalytics / GA-SDK-ROBLOX

Repository for GameAnalytics Roblox SDK
MIT License
68 stars 45 forks source link

addDesignEvent et al. should produce an error if provided a player instead of a user ID #122

Open Ozzypig-Gamefam opened 9 months ago

Ozzypig-Gamefam commented 9 months ago

The following call fails silently despite it being incorrect:

GameAnalytics:addDesignEvent(player, {
    eventId = "Buy:Apple",
})

The reason for this is that player should be player.UserId, which is not the way a good chunk of Roblox's API works. Therefore, the function should: