search

GameAnalytics / GA-SDK-UNREAL

A repository containing the GameAnalytics Unreal Engine 5 Plugin including documentation.
MIT License
54 stars 31 forks source link

Plugin is not compatible for 5.4 #4

Closed bluebubblebee closed 2 weeks ago

bluebubblebee commented 1 month ago

In UE 5.4 there is a compiler error on UEGameAnalytics.cpp in the StartupModule It looks like the FAnalyticsProviderGameAnalytics needs some parameters GameAnalyticsProvider = MakeShareable((new FAnalyticsProviderGameAnalytics());

dorin-ga commented 4 weeks ago

Hello, we have built and tested the latest plugin version using Unreal Engine 5.4.2 and it seems to work correctly in our tests. Also the constructor for FAnalyticsProviderGameAnalytics requires no parameters: https://github.com/GameAnalytics/GA-SDK-UNREAL/blob/016817501168b4002b14a106fee852ff4277f4a0/GameAnalytics/Source/GameAnalytics/Private/UEGameAnalytics.cpp#L199

Could you please post the whole error message here so we can investigate? Did you download the plugin from github or from the Unreal Marketplace?

If this is triggered by the UE_LOG macro formatting, it is a known issue and will be patched in the next version.

bluebubblebee commented 4 weeks ago

Thank you, I tried with the market place version for 5.3 as the 5.4 wasn't available just yet.

The error that I got is: UEGameAnalytics.cpp Line: 27 - no instance of overloaded function "MakeShareable" matches the argument list

UEGameAnalytics.cpp Line: 27 - object of abstract class type "FAnalyticsProviderGameAnalytics" is not allowed:
pure virtual function "IAnalyticsProvider::SetDefaultEventAttributes" has no overrider pure virtual function "IAnalyticsProvider::GetDefaultEventAttributesSafe" has no overrider pure virtual function "IAnalyticsProvider::GetDefaultEventAttributeCount" has no overrider pure virtual function "IAnalyticsProvider::GetDefaultEventAttribute" has no overrider

dorin-ga commented 4 weeks ago

I see, seems to be a problem with the marketplace version as those are already defined in the SDK, e.g: https://github.com/GameAnalytics/GA-SDK-UNREAL/blob/016817501168b4002b14a106fee852ff4277f4a0/GameAnalytics/Source/GameAnalytics/Private/UEGameAnalytics.cpp#L221

Let us take a look and we'll fix the marketplace version.

bluebubblebee commented 4 weeks ago

Thank you, I've just tested the version from Github with 5.4 and this one compiles, so it's a problem with the version on the marketplace