search

GameConnect / SourceBans

Advanced admin and ban management for the Source game engine
http://www.sourcebans.net
67 stars 30 forks source link

Show "Settings" link only for enabled plugins #36

Open ppalex7 opened 10 years ago

ppalex7 commented 10 years ago

I think it will be good to hide settings link for disabled plugins, because some plugins "runSettings" action can't work properly without overrides (from this plugin) for onBeginRequest

ErikMinekus commented 10 years ago

You need to be able to change settings even if the plugin is disabled. It should be a simple page for basic settings. What kind of overrides do you need in onBeginRequest for the settings page?

ppalex7 commented 10 years ago

At onBeginRequest I importing custom models, checking and adding to database nonexistence settings. Of course I could duplicate this code to the runSettings function, but i think it will looks strange.

ppalex7 commented 10 years ago

Changing the settings of disabled plugin - seems strange to me.