GameDevProject-S20 / Pre-Production

Pre-Production work for Split Ends!
0 stars 1 forks source link

Dialogue Bug Fix #334

Closed Thomas-Chabot closed 4 years ago

Thomas-Chabot commented 4 years ago

What am I addressing?

Closes #332

How/Why did I address it?

Originally the number of characters in text was being counted by a regular expression that stripped out tags and counted the number of characters not in tags. TextMeshPro has its own property to return the number of characters in text (TextInfo.CharacterCount), I'm not sure if this one strips out tags but from my testing it looks like it's giving the right values. Tested specifically with the encounter that was giving the issue and the character count was correct.

Reviewers

@GameDevProject-S20/bestteam

What should reviewers focus on?

Comments & Concerns