arie-rose
commented
4 years ago @DavidNeudorf I've merged my stuff into here and it's looking good!
Just have a look that I didn't override anything important in Items.csv that conflicted with changes Zach made. has_tag was not able to be added in time, but is_driving/is_walking looks great! Otherwise this looks great and I'll close my PR to allow you to merge this directly to main as soon as you're ready 👍
DavidNeudorf
What am I addressing?
closes #311 update encounters, update item tags and remove two with too much overlap.
Reviewers
@GameDevProject-S20/bestteam
What should reviewers focus on?
Comments & Concerns
Latest commit has the driving/walking conditions so it probably crashes. needs to be tested once all that is done. Otherwise I think stuff works, but as it is completely possible there are typos I'd super appreciate if someone is looking for final tasks to do to just read through the encounters or play the game farming as many encounters as possible and try to spot something.
encounter 1021 is currently false just needs has_tag and it should be good to go.