search

GameDevTecnico / cubos

A still very barebones game engine focused on voxels and data-oriented programming
https://cubosengine.org
MIT License
83 stars 36 forks source link

Stop using old serialization to load Settings #1102

Closed RiscadoA closed 6 months ago

RiscadoA commented 6 months ago

Description

Swaps old serialization code in Settings for direct JSON handling. Adds a test to cover the expected behavior.

Checklist

github-actions[bot] commented 6 months ago

PR Preview Action v1.4.7 :---: :rocket: Deployed preview to https://GameDevTecnico.github.io/cubos/docs-preview/pr-1102/ on branch gh-pages at 2024-03-20 12:31 UTC

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 77.96610% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 38.24%. Comparing base (c692ed3) to head (af8f45d). Report is 4 commits behind head on main.

:exclamation: Current head af8f45d differs from pull request most recent head 47e1e80. Consider uploading reports for the commit 47e1e80 to get more accurate results

Files Patch % Lines
engine/src/settings/plugin.cpp 59.37% 13 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1102 +/- ## ========================================== + Coverage 37.92% 38.24% +0.31% ========================================== Files 315 316 +1 Lines 25503 25551 +48 ========================================== + Hits 9673 9772 +99 + Misses 15830 15779 -51 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.