search

GameDevTecnico / cubos

A still very barebones game engine focused on voxels and data-oriented programming
https://cubosengine.org
MIT License
83 stars 36 forks source link

fix(rendering): destroy objects only if render device is alive #1133

Closed RiscadoA closed 5 months ago

RiscadoA commented 5 months ago

Description

Checklist

github-actions[bot] commented 5 months ago

PR Preview Action v1.4.7 :---: :rocket: Deployed preview to https://GameDevTecnico.github.io/cubos/docs-preview/pr-1133/ on branch gh-pages at 2024-04-23 20:32 UTC

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 0% with 94 lines in your changes are missing coverage. Please review.

:exclamation: No coverage uploaded for pull request base (main@3fc5a30). Click here to learn what that means. Report is 1 commits behind head on main.

Files Patch % Lines
core/src/gl/ogl_render_device.cpp 0.00% 93 Missing :warning:
core/src/gl/ogl_render_device.hpp 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1133 +/- ## ======================================= Coverage ? 40.65% ======================================= Files ? 327 Lines ? 25438 Branches ? 0 ======================================= Hits ? 10342 Misses ? 15096 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.