GameDevTecnico / cubos

A still very barebones game engine focused on voxels and data-oriented programming
https://gamedevtecnico.github.io/cubos/
MIT License
83 stars 23 forks source link

Implement file logging #1156

Closed roby2014 closed 3 months ago

roby2014 commented 4 months ago

Description

The implementation is: when logging (with cubos_debug, etc..), if the file was set, it also prints to the file stream. this means: data logged before setting the file, wont be logged

Checklist

github-actions[bot] commented 4 months ago

PR Preview Action v1.4.7 :---: :rocket: Deployed preview to https://GameDevTecnico.github.io/cubos/docs-preview/pr-1156/ on branch gh-pages at 2024-05-30 12:29 UTC

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 5.00000% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 40.34%. Comparing base (693d91e) to head (6aa712a).

:exclamation: Current head 6aa712a differs from pull request most recent head ced9275

Please upload reports for the commit ced9275 to get more accurate results.

Files Patch % Lines
core/src/log.cpp 5.00% 19 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1156 +/- ## ========================================== - Coverage 40.37% 40.34% -0.04% ========================================== Files 351 351 Lines 26030 26050 +20 ========================================== Hits 10509 10509 - Misses 15521 15541 +20 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

RiscadoA commented 3 months ago

You can merge this btw @roby2014