Closed fallenatlas closed 2 months ago
PR Preview Action v1.4.7
:---:
:rocket: Deployed preview to https://GameDevTecnico.github.io/cubos/preview/pr-1277/
on branch gh-pages
at 2024-07-22 23:05 UTC
Attention: Patch coverage is 0%
with 94 lines
in your changes missing coverage. Please review.
Project coverage is 36.19%. Comparing base (
071ab63
) to head (9fb7ea3
).
Files | Patch % | Lines |
---|---|---|
...c/physics/solver/penetration_constraint/plugin.cpp | 0.00% | 87 Missing :warning: |
...src/physics/constraints/penetration_constraint.cpp | 0.00% | 7 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@fallenatlas please share your resources for the physics engine to ease reviewing. The math looks right, but i don't know if I'd catch errors without a reference
Description
Note: I couldn't find how to apply restitution using accumulated impulses anywhere, which is ridiculous, so the implementation I have is based only on how Erin Catto does it in Box2D v3.0, which he says it's not the most accurate but it seems to work pretty well.
Checklist