Closed tomas7770 closed 1 month ago
PR Preview Action v1.4.7
:---:
:rocket: Deployed preview to https://GameDevTecnico.github.io/cubos/preview/pr-1287/
on branch gh-pages
at 2024-07-25 18:31 UTC
Attention: Patch coverage is 0%
with 186 lines
in your changes missing coverage. Please review.
Project coverage is 35.95%. Comparing base (
e20a16c
) to head (74f960d
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
On another note, is there a way to test this functionality?
On another note, is there a way to test this functionality?
I'm not sure how the testing framework works, but I figure the shadowAtlasPlugin
should be testable. The rest probably has the risk of slightly different behavior on different GPUs.
On another note, is there a way to test this functionality?
I'm not sure how the testing framework works, but I figure the
shadowAtlasPlugin
should be testable. The rest probably has the risk of slightly different behavior on different GPUs.
The CI can't handle GPU stuff properly, so yeah, it's not worth the hassle to write tests for these kind of stuff. Do ensure that we have good samples for these features though!
If could add a new render sample focused on shadows, it would be great.
Structure wise we should probably rename the previous render sample to render.main
or something, and add new samples under it, such as render.shadows
Description
Implements shadows for spot lights, including support for multiple lights and soft shadows.
shadowAtlasPlugin
creates and manages the shadow atlas, a large texture that holds the shadow maps for each spot light.shadowAtlasRasterizerPlugin
draws to the shadow maps.deferredShadingPlugin
has been modified to read from the shadow atlas, in order to draw shadows.Checklist