search

GameFoundry / bsfExamples

Example projects for the bs::framework
MIT License
63 stars 24 forks source link

Full Cotire Support #8

Closed cwfitzgerald closed 6 years ago

cwfitzgerald commented 6 years ago

This is the examples equivalent to https://github.com/GameFoundry/bsf/pull/142.

It also adds basic travis support.

BearishSun commented 6 years ago

Do we need cotire for examples since they are only one source file?

Also I don't plan on setting up CI for examples at the moment, and when I do I'd like to somehow re-use the travis/appveyor for both projects so I don't need to maintain mostly duplicate code.

cwfitzgerald commented 6 years ago

I would argue yes, as we want people who are reading the examples to know that (conditional) cotiring exists in the codebase and we have facilities to do that. People are much more likely to look at the examples then directly read the manual. We can remove cotire.cmake though.

That's also fine.

It would probably be easier to just close this PR and you can put in cotire and the colored output thing.

BearishSun commented 6 years ago

Makes sense. I've enabled cotire on the relevant targets, and the rest of the changes should be inherited from the framework's cmake.

cwfitzgerald commented 6 years ago

Unfortunately you do need the colored output function call in the top level example cmake because the changes made don't propagate up subdirectories so the examples are left without color.

Connor Fitzgerald Sent from my Phone. Please excuse my brevity.

On June 6, 2018 4:36:40 PM EDT, Marko Pintera notifications@github.com wrote:

Makes sense. I've enabled cotire on the relevant targets, and the rest of the changes should be inherited from the framework's cmake.

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/GameFoundry/bsfExamples/pull/8#issuecomment-395205366

BearishSun commented 6 years ago

I've moved that code into Properties.cmake, which gets included from the root CMakeLists.txt for examples, bsf and custom user projects. I haven't tested it but I think that should be fine?

cwfitzgerald commented 6 years ago

Ah yes, that's all good. Didn't see that, on mobile.

Connor Fitzgerald Sent from my Phone. Please excuse my brevity.

On June 6, 2018 4:50:22 PM EDT, Marko Pintera notifications@github.com wrote:

I've moved that code into Properties.cmake, which gets included from the root CMakeLists.txt for examples, bsf and custom user projects. I haven't tested it but I think that should be fine?

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/GameFoundry/bsfExamples/pull/8#issuecomment-395209210