search

GameGodS3 / DropPoint

Make drag-and-drop easier using DropPoint. Drag content without having to open side-by-side windows
https://droppoint.netlify.app/
GNU General Public License v3.0
901 stars 59 forks source link

Debian package contains unrelated program #23

Closed Natrox closed 2 years ago

Natrox commented 2 years ago

I installed the latest .deb package and it contained "tuxedo-control-center" and "tuxedo-keyboard" (kernel module). These programs seem to be unrelated. Perhaps packed into the .deb by accident?

I don't want to assume malice, but I immediately thought of either malware or bloatware.

Natrox commented 2 years ago

On second thought, this may be an issue with DebTap. I'll investigate.

GameGodS3 commented 2 years ago

Well, I am genuinely unaware of any such bloatware creeping up into the .deb package. All we did was use the Electron Builder package to automate the process of deploying packages for all Operating Systems. I shall look into it as well.

And well, I see you are using DebTap, and I believe that's for installing Debian packages in Arch, if I am not mistaken. Just wanted to let you know that the tar.gz and AppImage are available, in case of inconveniences caused by the .deb package.

Thank you and cheers

Natrox commented 2 years ago

Thank you. Yeah, I'm leaning towards a DebTap issue. I'll try the other releases. I generally prefer to use package management, which is why I used DebTap instead (even though it's generally to be avoided).

GameGodS3 commented 2 years ago

By far this is what I was able to find: https://forum.manjaro.org/t/atom-editor-cant-install-packages/72249/3

It seems to me that whenever you convert an electron app's .deb (in this case Atom Editor) using DebTap, it includes the tuxedo-control-center package.

On Sat, 12 Feb 2022 at 17:00, Sam Hardeman @.***> wrote:

Thank you. Yeah, I'm leaning towards a DebTap issue. I'll try the other releases. I generally prefer to use package management, which is why I used DebTap instead (even though it's generally to be avoided).

— Reply to this email directly, view it on GitHub https://github.com/GameGodS3/DropPoint/issues/23#issuecomment-1037160704, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANAWIT2547N65PT66LT7P5TU2ZAFXANCNFSM5OAXGHRA . You are receiving this because you commented.Message ID: @.***>

-- Sudev Suresh Sreedevi

Natrox commented 2 years ago

By far this is what I was able to find: https://forum.manjaro.org/t/atom-editor-cant-install-packages/72249/3 It seems to me that whenever you convert an electron app's .deb (in this case Atom Editor) using DebTap, it includes the tuxedo-control-center package. … On Sat, 12 Feb 2022 at 17:00, Sam Hardeman @.> wrote: Thank you. Yeah, I'm leaning towards a DebTap issue. I'll try the other releases. I generally prefer to use package management, which is why I used DebTap instead (even though it's generally to be avoided). — Reply to this email directly, view it on GitHub <#23 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANAWIT2547N65PT66LT7P5TU2ZAFXANCNFSM5OAXGHRA . You are receiving this because you commented.Message ID: @.> -- Sudev Suresh Sreedevi

Thank you for your efforts! I'll have to check why DebTap is doing this. My assumption is that the last release was built by someone on a Tuxedo laptop, which apparently come pre-installed with the control center and see it as a dependency.

I'll move on to that repository to investigate whether it's occurring in their latest release and see if I can propose a fix.

On the topic of DropPoint: It's great! I assume Electron was used to provide a cross-platform method of drag-and-dropping files? It's a pretty elegant solution, even though typically I'm not a fan of apps using Electron due to high memory usage. DropPoint seems to use ~120MB on my machine, which is not a big problem for me personally but still is relatively a lot.

I have some ideas for the app:

Overall, I am very happy with the program. It's really useful! Especially for work efficiency, it makes sharing stuff with multiple people really easy. Thank you for your hard work!

Do you mind if I fork DropPoint to work on the features I mentioned? When I complete them, I'll put in a pull request to contribute the changes back to the repository. Of course, if you don't like the changes, I can keep the fork and follow the GPL as expected. :)

GameGodS3 commented 2 years ago

Hey, thank you! :smile:

Out of the ones which you have mentioned, point 1 and point 2 are currently under development. I had to refactor the whole structure of how DropPoint deals with files to implement those features. You can try cloning the project and trying yourself :slightly_smiling_face:. I was trying to load the settings from a json file, and later implement it as a GUI settings modal along with the config file.

Grayscale icon is a great suggestion. I am always fond of implementing such user experience details if possible. Will definitely do that!

Point 3 and Point 5 is in the future plans. And that was the reason why I had thought of refactoring the whole thing.

Moreover, I should start documenting the whole thing for others to contribute more easily. Truth be told, erasing the spaghetti code and rewriting with less chaos was the reason the next release was delayed for so long.

I would love to have a pull request with Point 3 and Point 5 implemented! Please do go ahead. Also, for convenience of tracking the progress, could you make a new issue with those feature requests? I am closing this issue here and looking forward to your contribution.

Once again, thank you. Cheers!

Natrox commented 2 years ago

Will do, I'll make a new issue shortly. :)