Feature/UI rework - Githubissues

GameMakersToolkit / team-finder

All the components necessary to drive the GMTK Team Finder tools

Other

12 stars 7 forks source link

Feature/UI rework #279

Closed juve-938383 closed 1 year ago

juve-938383 commented 1 year ago

Ooooohhh...is this my first PR? 👀 Let's see if it gets merged.

Changes:

Advanced Search radio buttons now show default value;
Added the more contrasting blue for the Possessed Skill labels (because I'm stubborn). I called it real-blue since the other options are actually teal, despite being named blue. Maybe they should be renamed as well?
Removed the feminine version of Italian and Latinamerican Spanish languages because I find them redundant. (I made this change to my fork after I created the PR but it became part of the PR as well apparently)

Willdotwhite commented 1 year ago

@juve-938383 the first and third changes are excellent, thank you :+1:

Could you drop a screenshot for how the colours look please? If you grab an image and paste it here, Github will automatically upload and embed the image here

juve-938383 commented 1 year ago

It is actually the same colour Sara showed in a version of the site (or maybe it was the Figma design, not sure which one). I simply thought of implementing it since it never was implemented but I am sure there is a good reason that it wasn't so it is fine if the change is not approved.

Willdotwhite commented 1 year ago

The hex codes aren't quite right - could you please set them to the following?

#0090B5 (teal)
#0068E8 (indigo)

Cheers :D

juve-938383 commented 1 year ago

Done 👍

Willdotwhite commented 1 year ago

Changes look good other than the missing comma (which I only spotted thanks to the GitHub Action - don't review on mobile friends)

juve-938383 commented 1 year ago

sigh I am incredibly sorry for dragging such a small thing so long. 😞 I made the colour change straight away in Github and didn't even test it locally. Anyways, comma added now. Hopefully there is nothing else.

Willdotwhite commented 1 year ago

Don't worry about the timing, asynchronous work is never very quick; I know a guy who had an open PR for ~11 weeks

Thanks again for putting in your first PR!