GameMakersToolkit / team-finder

All the components necessary to drive the GMTK Team Finder tools
Other
12 stars 7 forks source link

Notify users of fallback contact via DM instead of channel ping #297

Closed Willdotwhite closed 5 months ago

Willdotwhite commented 5 months ago

Now when clicking the "Ping them on discord" button on the UI (ideally to be used when a user doesn't have the correct permissions to receive DMs from users), the user will be send a message from the server bot.

If a user has locked down their permissions such that they can't receive a DM from the bot, then they'll currently be stuck as uncontactable. However, given that the bot is currently also running the user permissions check on login, we shouldn't be able to get to this position for the majority of users who create a post under normal conditions.

I'd prefer to remove the ping channel entirely and rely on our onboarding process to catch users who can't receive messages, now that we have the ability to report posts as uncontactable. However, while we have the ping channel we might want to keep it as the ultimate fallback in case of exception user behaviour.

Screenshots

Normal; sender has a post on the site, all fields

image

Normal; sender has a post on the site, but not all fields

image

Normal; send doesn't have a post on the site image (The typo'd " has been fixed)

When a user has blocked all contact

image image