GameModsBR / VoiceChat

14 stars 13 forks source link

Possible concurrency issues with Minecraft packet handling. #1

Open Gliby opened 7 years ago

Gliby commented 7 years ago

https://github.com/GameModsBR/VoiceChat/tree/master/src/main/java/net/gliby/voicechat/common/networking/packets The issue is with the onMesssage code, If I recall correctly this function gets called on the network thread, possible concurrency issue, as well as stressing the network thread. A simple fix would be to schedule the code inside the function, so it would execute on the main Minecraft thread. I'll be reporting issues with my own code, if anyone wants to fix 'em.

Gliby commented 7 years ago

Fixed in 0.6.1a, https://github.com/GameModsBR/VoiceChat/tree/1.10.2/src/main/java/net/gliby/voicechat/common/networking/packets