search

GameOfLife / Unit-Lib

The Unit Library is a system that provides high level abstractions on top of the SuperCollider language.
25 stars 6 forks source link

added \timeScale spec #56

Open JVanBuskirk opened 8 years ago

JVanBuskirk commented 8 years ago

envelope_rel.scd was not rescale to the event time. I added copied the \timeScale spec from line_rel.scd. It seems to fix the problem.

woutersnoei commented 8 years ago

Hi JVanBuskirk, thanks for the pull request. I'm not sure though how and if this fix would solve the problem. What it effectively does is make the timeScale arg init rate instead of control rate, and I can't see in the source code why that would make any difference. The problem with the two _rel UMapDefs is that sometimes their 'u_dur' arg is not set correctly. This happens to both of them in some cases where the event is copied or immediately after the UMap is added to a chain. I've done some work on solving this a while ago, but perhaps there are still cases where it happens. Could you maybe explain when the envelope_rel did and did not rescale? Or was it all the time :-)?

JVanBuskirk commented 8 years ago

Hello. Now I can't recreate it. It was not working for envelope_rel.scd consistently in one session. After I changed the file to match line_rel, it worked. I reinstalled Unit-Lib everything works as expected. Sorry for the noise.

I did have one issue where the envelope did not update after editing the graphic envelope. I closed the gui. When I reopened it all of my edits were gone, but I could not recreate this issue after this first occurrence either.

Unit-Lib is outstanding. I will be using it in my computer music class this fall.