Large File downloads do not fail if curl error

GameServerManagers / LinuxGSM

The command-line tool for quick, simple deployment and management of Linux dedicated game servers.

https://linuxgsm.com

MIT License

4.28k stars 818 forks source link

Large File downloads do not fail if curl error #2421

Open dgibbs64 opened 5 years ago

dgibbs64 commented 5 years ago

User Story

If a large download fails using curl it does not cause a fatal error instead it simply carries on.

Basic info

Command: Install

Further Information

It is worth checking how all downloads handle when failing to ensure they cause a fatal exit.

To Reproduce

Use a game server that is non-steam and cause the download to fail

Expected behaviour

issue-label-bot[bot] commented 5 years ago

Issue-Label Bot is automatically applying the label type: bug to this issue, with a confidence of 0.96. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

Frisasky commented 5 years ago

well i think maybe it has something do to with cloudflare, some user also report theres trouble downloading large file(1GB+) and myself experienced sudden throttle while download such large file, im thinking whether is it a good idea to move to some other CDN services. For free, incapsula, or cheap cdn service, like FDCserver's (5USD/TB)

dgibbs64 commented 5 years ago

The failure was because the file didn't exist when developing a game. There is no error checking in place currently for failed curl downloads.

Bourne-ID commented 5 years ago

There's a few incidents where a command is expected to finish successfully, or error reporting doesn't retry/exit the script (tar extracts is another instance). We need to agree on an exit code or strategy when these happen...

Claiyc commented 2 years ago

Is this still relevant?