search

GameServerManagers / LinuxGSM

The command-line tool for quick, simple deployment and management of Linux dedicated game servers.
https://linuxgsm.com
MIT License
4.24k stars 813 forks source link

[BUG] './vhserver pd' posts password in plaintext #3286

Closed derekslenk closed 3 years ago

derekslenk commented 3 years ago

User Story

As a VHServer, I expect to be able to run './vhserver pd' and see the server details on termbin without the password in the launch command exposed

Basic info

Further Information

I have my server up and running and just wanted to see what pd gave me, and noticed that in the command-line output that the password was listed:

Command-line` Parameters
=================================
 ./valheim_server.x86_64 -name 'Chums UP!' -password cleartextpass -port 2456 -world DextersLab -public 1

To Reproduce

Steps to reproduce the behaviour:

  1. Start vhserver: ./vhserver start
  2. ./vhserver pd
  3. Output on termbin contains passwords

Expected behaviour

I would expect my password to be masked since the menu option says that passwords will be removed.

dgibbs64 commented 3 years ago

looks like its specifically the start parameters that are the issue.

derekslenk commented 3 years ago

I can provide my real world example if needed, I would just rather not post it directly in the issue.

dgibbs64 commented 3 years ago

It should be OK without it. We can test this one. Thank you for reporting it 👍

github-actions[bot] commented 2 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.