search

GameServerManagers / LinuxGSM

The command-line tool for quick, simple deployment and management of Linux dedicated game servers.
https://linuxgsm.com
MIT License
4.32k stars 821 forks source link

[Bug]: Discord alert on update uses the old version not the new one #4696

Open fontivan opened 1 week ago

fontivan commented 1 week ago

User story

As a user, I want the discord alert to tell me what version the game has been updated to

Game

Factorio

Linux distro

Debian 12

Command

command: update

Further information

When I run fctrserver update, it performs the update as expected. I have configured a discord webhook for notifiations, but the notification reports that the game has been updated to the old version instead of the new one

Relevant log output

~$ ./fctrserver update
[  OK  ] Updating fctrserver: Checking for update: factorio.com

Update available
* Local build: 2.0.13 linux64
* Remote build: 2.0.14 linux64
* Branch: stable

####################################################################################################################################################### 100.0%####################################################################################################################################################### 100.0%
OK
extracting factorio_headless_linux64-2.0.14.tar.xz...OK
clearing LinuxGSM tmp directory...OK
[  OK  ] Updating fctrserver: Sending Discord alert

Steps to reproduce

  1. Run update (and update must actually be available as the notification does not send if no update is performed)
  2. Wait for notification to send
  3. Observe notification and note the version reported in the message
fontivan commented 1 week ago

image