GameServerManagers / LinuxGSM

The command-line tool for quick, simple deployment and management of Linux dedicated game servers.
https://linuxgsm.com
MIT License
4.3k stars 819 forks source link

[ts3server] Bugs showing in details command #744

Closed derklompi closed 8 years ago

derklompi commented 8 years ago

Hi, I just created a new TS3 Server and the "details" command is showing 2 non working lines.

  1. ts3server Script Details ========================================= /home/lgsm/ts3_TZF/functions/command_details.sh: line 149: [: : integer expression expected Service name: ts3-server
  2. Backups ================================= No Backups created /home/lgsm/ts3_TZF/functions/command_details.sh: line 640: fn_parms: command not found

I removed all functions and fetched them again, but nothing changed.

~Flam

dgibbs64 commented 8 years ago

thanks for reporting this. The details command is going to have a massive spring clean in the next couple of months. Im gunna make the code a lot cleaner and simpler than it currently is. So these sort of errors should be reduced. So I will iron out this issue then :)

derklompi commented 8 years ago

Always happy if I can help ;)

UltimateByte commented 8 years ago

Yep, thanks for reporting.

  1. is fixed ./ts3server update-functions
  2. is on the todo list. https://github.com/dgibbs64/linuxgsm/blob/master/functions/command_details.sh#L149
derklompi commented 8 years ago

Yep, The BackUp Line works now :)

oalaro commented 8 years ago
=================================
Teamspeak 3
Linux Game Server Manager
by Daniel Gibbs
http://gameservermanagers.com
Contributors: http://gameservermanagers.com/contib
=================================
    fetching functions/install_serverdir.sh...OK

Server Directory
=================================

/home/ts3server

Continue [y/N]y
mkdir: created directory `/home/ts3server/serverfiles'
    fetching functions/check_deps.sh...OK

Checking Dependecies
=================================
curl
ca-certificates
libstdc++6:i386
    fetching functions/install_ts3.sh...OK
    fetching functions/info_distro.sh...OK
downloading teamspeak3-server_linux_amd64-3.0.12.tar.bz2...OK
extracting teamspeak3-server_linux_amd64-3.0.12.tar.bz2...OK

When doing a fresh install it downloads 3.0.12 . Can be easily fixed by just updating after install

UltimateByte commented 8 years ago

@oalaro Thanks for reporting. You're telling me that i fixed the update number but forgot about the installer version check ? We definitely need to make that in one unique function. I'll check that out.

UltimateByte commented 8 years ago

@oalaro , The fix has been made for that, pull request done. Will be fixed soon. Thanks for reporting, i wouldn't have noticed otherwise.

UltimateByte commented 8 years ago

Fixed both :)

lock[bot] commented 6 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.