search

GameTactic / Room

The "Room" component of Gametactic. Some say, its heart of the GameTactic.
GNU General Public License v3.0
14 stars 4 forks source link

Feature/15 login #187

Closed nathcouret closed 4 years ago

NikoGrano commented 4 years ago

I think the providers data should be fetched from the microservice, rather than hardcoding it into the app.

NikoGrano commented 4 years ago

@bryansamuel1 Why does this PR contain also translations?

bryansamuel1 commented 4 years ago

@Ataww @NikoGrano @Eirmas This PR was created as a merge into MASTER not DEVELOP. I have changed it to DEVELOP now so please re PR / check

NikoGrano commented 4 years ago

Oh, thanks!

@Ataww Please take note and resolve conflicts.

NikoGrano commented 4 years ago

Please also note #199 in this PR.

NikoGrano commented 4 years ago

Also note #200

NikoGrano commented 4 years ago

I added documentation to README.md of authentication microservice in 406114d8. Feel free check that out, I dont want paste everything here.

Information is related in both #199 and #200.

nathcouret commented 4 years ago

I added documentation to README.md of authentication microservice in 406114d8. Feel free check that out, I dont want paste everything here.

Information is related in both #199 and #200.

Will do thanks

NikoGrano commented 4 years ago

@Ataww Would you mind update us with the status 😛

bryansamuel1 commented 4 years ago

@NikoGrano can you squash and merge this into dev please?

bryansamuel1 commented 4 years ago

Wooo finally merged!!!

NikoGrano commented 4 years ago

Used administrator privileges to merge this due unsigned commits.