Update the pinned tabs to work with tactics

[bryansamuel1]

• Improve the styling of the pinned tabs
• Add a badge to the tactics list if it is pinned
• Add context menu to tabs so it can be unpinned
• Sync tabs and tactics so when a user clicks on a tab the tactic list is updated and vice versa
• Fixed long tactic names on both the pinned tabs and tactics list
• Added in some simple logic around users who are viewing tactics

[Eirmas]

I think we should remove the badge to show if a tactic is pinned or not, its unnecessary because you can just have a look at the pinned tactic tabs. It also gets a bit messy to the eye - too much information in too little space

Can we also replace the menu context when you rightclick a pinned tab with something as simple as a small "x" to the right of the tactic name to unpin it? Looks very weird and non-userfriendly when it falls under the map. If we want to keep the context we would have to add logic to hide the map when the context is open, but i still think having a little "x" would be cleaner

[bryansamuel1]

I think we should remove the badge to show if a tactic is pinned or not, its unnecessary because you can just have a look at the pinned tactic tabs. It also gets a bit messy to the eye - too much information in too little space

Can we also replace the menu context when you rightclick a pinned tab with something as simple as a small "x" to the right of the tactic name to unpin it? Looks very weird and non-userfriendly when it falls under the map. If we want to keep the context we would have to add logic to hide the map when the context is open, but i still think having a little "x" would be cleaner

We won't be removing the tab icon from the Tactics list as it is a core requirement. Users will need to be able to quickly see what Tactics within the list are pinned and which ones aren't. It agree with you that you can look at the pinned Tab but when the Tactics list grows and you have Tactics in sub collections being able to see quickly which ones are Pinned will be a nice experience for the user. I have spoken to Rites about the Tactics list and he is happy with the styling so far, but I challenge you to find a different way of displaying this information :)

I will look at putting an X there instead, I am just conscious of the small amount of space for the text so I didn't want to overload the area. I will have a fiddle and look around and propose some alternatives. For this ticket though it is acceptable and I will create another ticket to look into.