Fix code scanning alert - Polynomial regular expression used on uncontrolled data

Gamebuster19901 / Roll

3 stars 0 forks source link

Fix code scanning alert - Polynomial regular expression used on uncontrolled data #19

Closed Gamebuster19901 closed 1 year ago

Gamebuster19901 commented 1 year ago

Tracking issue for:

[x] https://github.com/Gamebuster19901/Roll/security/code-scanning/1

Gamebuster19901 commented 1 year ago

While the data does contain some user input, it comes from a trusted source, and the user supplied data can only be so large.

The time it takes to parse the data via regex, even if it contains data specifically designed to create a denial of service, is negligible compared to the time it takes to establish a connection and download the PDF from DNDBeyond.