search

Gamemode4Dev / GM4_Datapacks

Gamemode 4 is a collection of modular Minecraft Datapacks that change or expand on the vanilla experience whilst keeping the vanilla feel. Our modules are developed with a focus on usability and efficiency.
https://gm4.co
GNU General Public License v3.0
108 stars 56 forks source link

Tunnel Bores: 1.20.6 version has duplication bug #1009

Open Bloo-dev opened 2 months ago

Bloo-dev commented 2 months ago

Describe the bug Tunnel Bores' 1.21 version had a duplication bug where coal and rails were not correctly removed from the chest minecart's inventory once the final item is reached. This bug likely also affects the 1.20.6 version. Confirmation needed.

To Reproduce Steps to reproduce the behavior:

  1. Place a Tunnel Bore, including a Chest Minecart
  2. Place a single rail and coal into the Chest Minecart
  3. Start the Tunnel Bore
  4. Note how the items are not used up.

Expected behavior The items should be used up.

Fix This is due to an item count of 0 being invalid as of 1.20.6, therefore the command fails. An explicit item delete command needs to be added tot he count 0 case.

BluePsychoRanger commented 1 month ago

Fixed in commit 26034bc https://github.com/Gamemode4Dev/GM4_Datapacks/commit/26034bc34ec1a143d9986c50017b3a6800581711

misode commented 1 month ago

@BluePsychoRanger That commit was only made to master after ver/1.20.5 was created. This is still an issue in 1.20.5/6

BluePsychoRanger commented 1 month ago

I see. My bad. How do we push changes to other branches?