Gamemode4Dev / GM4_Datapacks

Gamemode 4 is a collection of modular Minecraft Datapacks that change or expand on the vanilla experience whilst keeping the vanilla feel. Our modules are developed with a focus on usability and efficiency.
https://gm4.co
GNU General Public License v3.0
115 stars 57 forks source link

[Important] Holographic Tags Accept ANY item instead of just Nametags #1026

Closed Bloo-dev closed 3 months ago

Bloo-dev commented 3 months ago

Describe the bug Placing any renamed item in an Item Frame deletes teh item and turns it into a Holographic tag, thereby causing item loss.

To Reproduce Steps to reproduce the behavior:

  1. Place an Item Frame
  2. Rename some item
  3. Place it in the Item Frame
  4. Watch as the item is deleted and replaced by a Holographic Tag

Expected behavior Only Nametags should be able to make Holographic Tags.

Fix The issue was tracked down to a change in the data checks caused by the 1.20.6 update, causing the check to succeed for any item with a custom name, not just minecraft:nametag.

This fix should be backported to 1.20.6 as well as 1.21.

Environment

Additional context Spotted thanks to the reports of two users on our Discord: