search

Gamemode4Dev / GM4_Datapacks

Gamemode 4 is a collection of modular Minecraft Datapacks that change or expand on the vanilla experience whilst keeping the vanilla feel. Our modules are developed with a focus on usability and efficiency.
https://gm4.co
GNU General Public License v3.0
115 stars 57 forks source link

Fix Holographic Tags Accepting Any Item #1027

Closed BPR02 closed 3 months ago

BPR02 commented 3 months ago

Fixes #1026

SpecialBuilder32 commented 3 months ago

Why use an entity predicate instead of just modifying the existing if items entity @s contents *[custom_name] ... to use name_tag[custom_name]?

I don't know the performance difference, but I figure one item check is better than two? Unless maybe not selecting as many entities is worth it?

BPR02 commented 3 months ago

The entity predicate already existed and it was the first way to fix it that came to mind. Not sure which one's better.