Gamemode4Dev / GM4_Datapacks

Gamemode 4 is a collection of modular Minecraft Datapacks that change or expand on the vanilla experience whilst keeping the vanilla feel. Our modules are developed with a focus on usability and efficiency.
https://gm4.co
GNU General Public License v3.0
115 stars 58 forks source link

Build Pipeline Generates Broken `init.mcfunction` Files for Old Minecraft Versions #1066

Open Bloo-dev opened 2 weeks ago

Bloo-dev commented 2 weeks ago

Describe the bug The init.mcfunction of modules downloaded for old versions (tested for 1.14) are not able to be installed as the init.mcfunction contains malformed mcfunction code.

To Reproduce Steps to reproduce the behavior:

  1. Download Liquid Tanks for 1.14
  2. Create a new 1.14 world and put the module in the datapacks folder
  3. Run /reload
  4. Observe how Gamemode 4 announces 'updating', but the module does not install itself.

Expected behavior The module should install itself.

Fix The problem is caused by the pipeline adding double speechmarks in the module update/version lists CustomName tag in init.mcfunction, see screenshot below.

Screenshots Image

Environment

Additional context Additional older versions may be affected.