search

Gamemode4Dev / GM4_Datapacks

Gamemode 4 is a collection of modular Minecraft Datapacks that change or expand on the vanilla experience whilst keeping the vanilla feel. Our modules are developed with a focus on usability and efficiency.
https://gm4.co
GNU General Public License v3.0
112 stars 56 forks source link

Cooler Caves replaces nether portal with water #325

Closed iFuzion77 closed 2 years ago

iFuzion77 commented 4 years ago

When entering a new part of the world, from the nether to the overworld, the nether portal gets replaced by the cooler caves module with water in snowy biomes.

Steps to reproduce the behavior: 1 - Build a nether portal in the nether where a snowy biome would be in the overworld 2 - Go through the portal 3 - In the overworld, the portal should be replaced with water once Orbis and Cooler Caves ahs processed the chunk

Expected behavior Nether portal not replaced by water

Fix Not sure

Environment

Additional context I used the seed 113318802, I think the world was generated in 1.13, but I'm now playing it on 1.14.4 The coords of the portal I built in the nether are 424 ~ 478

2019-11-19_18 06 37 2019-11-19_18 22 10

misode commented 4 years ago

Cooler Caves replaces lava lakes with water because (1) lava doesn't fit in snowy caves and (2) the lava would otherwise melt the ice around it. However chunks aren't processed all in the same tick. This could sometimes create obsidian borders between chunks. Thus I decided to also replace all obsidian with water.

There are 3 possible fixes:

  1. Don't replace lava lakes with water
  2. Replace lava lakes with obsidian instead of water
  3. Only replace obsidian if it doesn't have a nether portal next to it.
    • This would be the ideal solution, but it would require more difficult block scanning.

@sparks0 @SpecialBuilder32 @Bloo-dev I'd like to get your opinion on this.

Nathan22211 commented 4 years ago

maybe don't replace obsidian

misode commented 4 years ago

maybe don't replace obsidian

@Nathan22211 That's not possible because of this:

This could sometimes create obsidian borders between chunks

misode commented 4 years ago

@sparks0 @Bloo-dev @SpecialBuilder32 Bump

Bloo-dev commented 4 years ago

Interesting. I don't see an easy way of fixing this and would just leave it in.