Gamemode4Dev / GM4_Datapacks

Gamemode 4 is a collection of modular Minecraft Datapacks that change or expand on the vanilla experience whilst keeping the vanilla feel. Our modules are developed with a focus on usability and efficiency.
https://gm4.co
GNU General Public License v3.0
115 stars 57 forks source link

Suggestion/Discussion - XP storage mending #385

Open Levertion opened 4 years ago

Levertion commented 4 years ago

I cannot find any previous discussion about whether XP storage should support mending.

I would like it to support mending on withdrawal. This would allow better farms to be made utilising other modules (such as a Forterra farm which doesn't require owning very many pickaxes).

Issues:

Further ideas:

Thanks!

Bloo-dev commented 4 years ago

For the time being there is a temporary work around:

The reason why mending doesn't work with any of our xp-Storage modules is that the Experience Orbs dropped by them are purely decorational to prevent nearby players from stealing your xp. I don't think any changes will be made to "emulate" mending, it's more likely that those xp orbs might get a real xp value.

SpecialBuilder32 commented 4 years ago

In previous versions at least, the player absorbed xp slower than 20hz, meaning that giving the orbs actual value resulted in an xp-swarm around the player. Not good for server performance and that swarm could also be leeched by another player.

Levertion commented 4 years ago

The alternative of course is to file the Minecraft bug and then strongarm @boq or @slicedlime into fixing it (/s for that second half)

BluePsychoRanger commented 3 years ago

This is easily possible in 1.17 using /item modify